Exam Certified Platform Developer II topic 1 question 47 discussion

Actual exam question from Salesforce's Certified Platform Developer II

Question #: 47
Topic #: 1

[All Certified Platform Developer II Questions]

trigger AssignOwnerByRegion on Account ( before insert, before update )
{
List<Account> accountList = new List<Account>();
for( Account anAccount : trigger.new )
{
Region__c theRegion = [
SELECT Id, Name, Region_Manager__c

FROM Region__c -
WHERE Name = :anAccount.Region_Name__c
];
anAccount.OwnerId = theRegion.Region_Manager__c;
accountList.add( anAccount );
}
update accountList;
}
Consider the above trigger intended to assign the Account to the manager of the Account's region.
Which two changes should a developer make in this trigger to adhere to best practices? (Choose two.)

A. Use a Map to cache the results of the Region__c query by Id.
B. Move the Region__c query to outside the loop.
C. Remove the last line updating accountList as it is not needed.
D. Use a Map accountMap instead of List accountList.

Show Suggested Answer

Suggested Answer: BC 🗳️

by sajjankrgupta at Dec. 10, 2020, 12:48 a.m.

Comments

Submit Cancel

sajjankrgupta

Highly Voted 4 years ago

Using a SOQL query inside for loop is bad practice and since it is before insert/update no need to perform DML. Ans is B and C.

upvoted 34 times

...

AB1993

Highly Voted 3 years, 4 months ago

B & C is the correct answer

upvoted 9 times

...

Jeet89123

Most Recent 7 months ago

Selected Answer: BC

B and C correct as per best parctices

upvoted 1 times

...

MetaLojiqTee

1 year, 5 months ago

Selected Answer: BC

B) Performing Queries inside a loop is not good practice, C) Changes made to records retrieved from 'Before' trigger context are automatically persisted if the trigger transaction completes successfully

upvoted 1 times

...

ram12313

1 year, 9 months ago

B&C is correct if we're only talking about best practices. But we still need to tidy it up a bit like code below. trigger AssignOwnerByRegion on Account ( before insert, before update ) { Set<String> acctRegionNames = new Set<String>(); for( Account acc : Trigger.new){ acctRegionNames.add(acc.Region_Name__c); } Map<String, String> regionMap = new Map<String, String>(); for( Region__c reg : [SELECT Name, Region_Manager__c FROM Region__c Name IN :acctRegionNames]){ regionMap.put(reg.Name, reg.Region_Manager__c); } for( Account anAccount : trigger.new ){ if(regionMap.containsKey(anAccount.Name)){ anAccount.OwnerId = regionMap.get(anAccount.Name); } } }

upvoted 4 times

...